Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add bootstrapped modules into platform modules list #13740

Closed
wants to merge 2 commits into from
Closed

fix(core): add bootstrapped modules into platform modules list #13740

wants to merge 2 commits into from

Conversation

DzmitryShylovich
Copy link
Contributor

@DzmitryShylovich DzmitryShylovich commented Jan 1, 2017 •
edited

Closes #12015

Description:
Platform modules list is never updated thus it's always empty. This is why nothing happens when platform is getting destroyed.

@DzmitryShylovich DzmitryShylovich changed the title WIP fix(core): add bootstrapped modules into platform modules list Jan 1, 2017
@vicb vicb added area: core Issues related to the framework runtime action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 2, 2017
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Jan 28, 2017
@mhevery mhevery closed this in 863285a Jan 29, 2017
@DzmitryShylovich DzmitryShylovich deleted the gh/12015 branch January 29, 2017 19:06
mhevery pushed a commit that referenced this pull request Feb 2, 2017
@mhevery
fix(core): add bootstrapped modules into platform modules list (#13740)
32870d8 
Closes #12015

PR Close #13740
mhevery pushed a commit that referenced this pull request Feb 3, 2017
@mhevery
fix(core): add bootstrapped modules into platform modules list (#13740)
250dbc4 
Closes #12015

PR Close #13740
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
fix(core): add bootstrapped modules into platform modules list (angul…
cc1b6ef 
…ar#13740)

Closes angular#12015

PR Close angular#13740
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@juleskremer
fix(core): add bootstrapped modules into platform modules list (angul…
0b60a7f 
…ar#13740)

Closes angular#12015

PR Close angular#13740
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

app not being destroyed when destroying the platform (PlatformRef)
4 participants
@DzmitryShylovich @mhevery @vicb @googlebot